zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server
Date Thu, 15 Aug 2019 16:56:17 GMT
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration
on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314397411
 
 

 ##########
 File path: zookeeper-server/src/test/java/org/apache/zookeeper/test/ObserverMasterTest.java
 ##########
 @@ -112,15 +109,29 @@ private PortForwarder setUp(final int omProxyPort) throws IOException
{
 
         OM_PORT = PortAssignment.unique();
 
-        String quorumCfgSection =
-                "server.1=127.0.0.1:" + (PORT_QP1)
-                        + ":" + (PORT_QP_LE1) + ";" +  CLIENT_PORT_QP1
-                        + "\nserver.2=127.0.0.1:" + (PORT_QP2)
-                        + ":" + (PORT_QP_LE2) + ";" + CLIENT_PORT_QP2
-                        + "\nserver.3=127.0.0.1:"
-                        + (PORT_OBS)+ ":" + (PORT_OBS_LE) + ":observer" + ";" + CLIENT_PORT_OBS;
+        String quorumCfgSection = "server.1=127.0.0.1:"
 
 Review comment:
   it is worth reverting
   can you take a look to all this similar cases in tests ?
   I won't add any other comments on this kind of issue

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message