zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server
Date Thu, 15 Aug 2019 16:40:06 GMT
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration
on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314395112
 
 

 ##########
 File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java
 ##########
 @@ -164,60 +164,52 @@ public MainThread(int myid, String quorumCfgSection) throws IOException
{
             this(myid, quorumCfgSection, true);
         }
 
-        public MainThread(int myid, String quorumCfgSection, Integer secureClientPort, boolean
writeDynamicConfigFile)
-                throws  IOException {
-            this(myid, UNSET_STATIC_CLIENTPORT, JettyAdminServer.DEFAULT_PORT, secureClientPort,
-                    quorumCfgSection, null, null, writeDynamicConfigFile, null);
+        public MainThread(int myid, String quorumCfgSection, Integer secureClientPort, boolean
writeDynamicConfigFile) throws IOException {
+            this(myid, UNSET_STATIC_CLIENTPORT, JettyAdminServer.DEFAULT_PORT, secureClientPort,
quorumCfgSection, null, null, writeDynamicConfigFile, null);
         }
 
-        public MainThread(int myid, String quorumCfgSection, boolean writeDynamicConfigFile)
-                throws IOException {
+        public MainThread(int myid, String quorumCfgSection, boolean writeDynamicConfigFile)
throws IOException {
             this(myid, UNSET_STATIC_CLIENTPORT, quorumCfgSection, writeDynamicConfigFile);
         }
 
-        public MainThread(int myid, int clientPort, String quorumCfgSection, boolean writeDynamicConfigFile)
-                throws IOException {
+        public MainThread(int myid, int clientPort, String quorumCfgSection, boolean writeDynamicConfigFile)
throws IOException {
             this(myid, clientPort, JettyAdminServer.DEFAULT_PORT, quorumCfgSection, null,
null, writeDynamicConfigFile);
         }
-        
-        public MainThread(int myid, int clientPort, String quorumCfgSection, String peerType,
boolean writeDynamicConfigFile)
-                throws IOException {
+
+        public MainThread(int myid, int clientPort, String quorumCfgSection, String peerType,
boolean writeDynamicConfigFile) throws IOException {
             this(myid, clientPort, JettyAdminServer.DEFAULT_PORT, quorumCfgSection, null,
peerType, writeDynamicConfigFile);
         }
 
-        public MainThread(int myid, int clientPort, String quorumCfgSection, boolean writeDynamicConfigFile,
-                          String version) throws IOException {
-            this(myid, clientPort, JettyAdminServer.DEFAULT_PORT, quorumCfgSection, null,
-                    null, writeDynamicConfigFile, version);
+        public MainThread(int myid, int clientPort, String quorumCfgSection, boolean writeDynamicConfigFile,
String version) throws IOException {
+            this(myid, clientPort, JettyAdminServer.DEFAULT_PORT, quorumCfgSection, null,
null, writeDynamicConfigFile, version);
         }
 
-        public MainThread(int myid, int clientPort, String quorumCfgSection, String configs)
-                throws IOException {
+        public MainThread(int myid, int clientPort, String quorumCfgSection, String configs)
throws IOException {
             this(myid, clientPort, JettyAdminServer.DEFAULT_PORT, quorumCfgSection, configs,
null, true);
         }
 
-        public MainThread(int myid, int clientPort, int adminServerPort, String quorumCfgSection,
-                String configs)  throws IOException {
+        public MainThread(int myid, int clientPort, int adminServerPort, String quorumCfgSection,
String configs) throws IOException {
             this(myid, clientPort, adminServerPort, quorumCfgSection, configs, null, true);
         }
 
-        public MainThread(int myid, int clientPort, int adminServerPort, String quorumCfgSection,
-                String configs, String peerType, boolean writeDynamicConfigFile)
-                throws IOException {
+        public MainThread(int myid, int clientPort, int adminServerPort, String quorumCfgSection,
String configs, String peerType, boolean writeDynamicConfigFile) throws IOException {
             this(myid, clientPort, adminServerPort, quorumCfgSection, configs, peerType,
writeDynamicConfigFile, null);
         }
 
-        public MainThread(int myid, int clientPort, int adminServerPort, String quorumCfgSection,
-                          String configs, String peerType, boolean writeDynamicConfigFile,
String version) throws IOException {
+        public MainThread(int myid, int clientPort, int adminServerPort, String quorumCfgSection,
String configs, String peerType, boolean writeDynamicConfigFile, String version) throws IOException
{
             this(myid, clientPort, adminServerPort, null, quorumCfgSection, configs, peerType,
writeDynamicConfigFile, version);
         }
 
-        public MainThread(int myid, int clientPort, int adminServerPort, Integer secureClientPort,
-                          String quorumCfgSection, String configs, String peerType, boolean
writeDynamicConfigFile, String version)
-                throws IOException {
+        public MainThread(int myid, int clientPort, int adminServerPort, Integer secureClientPort,
String quorumCfgSection, String configs, String peerType, boolean writeDynamicConfigFile,
String version) throws IOException {
             tmpDir = ClientBase.createTmpDir();
-            LOG.info("id = " + myid + " tmpDir = " + tmpDir + " clientPort = "
-                    + clientPort + " adminServerPort = " + adminServerPort);
+            LOG.info("id = "
 
 Review comment:
   it is worth reverting

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message