zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server
Date Thu, 15 Aug 2019 15:32:25 GMT
TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration
on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314366835
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/SaslClientCallbackHandler.java
 ##########
 @@ -50,36 +51,32 @@ public void handle(Callback[] callbacks) throws UnsupportedCallbackException
{
             if (callback instanceof NameCallback) {
                 NameCallback nc = (NameCallback) callback;
                 nc.setName(nc.getDefaultName());
-            }
-            else {
+            } else {
                 if (callback instanceof PasswordCallback) {
-                    PasswordCallback pc = (PasswordCallback)callback;
+                    PasswordCallback pc = (PasswordCallback) callback;
                     if (password != null) {
                         pc.setPassword(this.password.toCharArray());
                     } else {
-                        LOG.warn("Could not login: the {} is being asked for a password,
but the ZooKeeper {}" +
-                          " code does not currently support obtaining a password from the
user." +
-                          " Make sure that the {} is configured to use a ticket cache (using"
+
-                          " the JAAS configuration setting 'useTicketCache=true)' and restart
the {}. If" +
-                          " you still get this message after that, the TGT in the ticket
cache has expired and must" +
-                          " be manually refreshed. To do so, first determine if you are using
a password or a" +
-                          " keytab. If the former, run kinit in a Unix shell in the environment
of the user who" +
-                          " is running this Zookeeper {} using the command" +
-                          " 'kinit <princ>' (where <princ> is the name of the
{}'s Kerberos principal)." +
-                          " If the latter, do" +
-                          " 'kinit -k -t <keytab> <princ>' (where <princ>
is the name of the Kerberos principal, and" +
-                          " <keytab> is the location of the keytab file). After manually
refreshing your cache," +
-                          " restart this {}. If you continue to see this message after manually
refreshing" +
-                          " your cache, ensure that your KDC host's clock is in sync with
this host's clock.",
-                          new Object[]{entity, entity, entity, entity, entity, entity, entity});
+                        LOG.warn("Could not login: the {} is being asked for a password,
but the ZooKeeper {}"
+                                         + " code does not currently support obtaining a
password from the user."
 
 Review comment:
   Reformatting...
   
   Align `+`s with the initial `"`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message