zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server
Date Thu, 15 Aug 2019 15:23:56 GMT
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration
on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314292174
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/client/ZooKeeperSaslClient.java
 ##########
 @@ -442,11 +428,9 @@ public boolean clientTunneledAuthenticationInProgress() {
                 }
 
                 // 2. SASL authentication has succeeded or failed..
-                if (!gotLastPacket) {
-                    // ..but still in progress, because there is a final SASL
-                    // message from server which must be received.
-                    return true;
-                }
+                // ..but still in progress, because there is a final SASL
+                // message from server which must be received.
+                return !gotLastPacket;
 
 Review comment:
   The final result is the same, but the flow is changing a little.
   I would be more comfortable to keep it has it was before, if checkstyle would be happy


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message