zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #1054: ZOOKEEPER-1112: Add support for C client for SASL authentication
Date Wed, 14 Aug 2019 18:44:15 GMT
eolivelli commented on a change in pull request #1054: ZOOKEEPER-1112: Add support for C client
for SASL authentication
URL: https://github.com/apache/zookeeper/pull/1054#discussion_r314026674
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/util/SecurityUtils.java
 ##########
 @@ -153,6 +155,11 @@ public SaslClient run() throws SaslException {
     public static SaslServer createSaslServer(final Subject subject,
             final String protocol, final String serverName,
             final CallbackHandler callbackHandler, final Logger LOG) {
+        // required by c client api - Sasl.QOP="auth" is not set
+        // by default although stated in javadoc (Sun JRE 1.6.0_26-b03)
+        HashMap<String, Object> props = new HashMap<String, Object>();
 
 Review comment:
   May this change have any impact on existing setups?
   If I understand correctly this will alter someway how the JAAS runtime operates.
   
   Should we make it configurable?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message