zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] TisonKun commented on issue #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server
Date Wed, 14 Aug 2019 14:37:07 GMT
TisonKun commented on issue #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#issuecomment-521273094
 
 
   I have redone the task enable checkstyle configuration and resolve conflict. Basically
it focuses on whitespaces, imports, operators on a new line, redundant or out-of-order modifiers,
TODO comments, and if/else also with curly.
   
   For javadoc discussion, let's move to ZOOKEEPER-3469.
   
   For variable/class names discussion(whether change it or not on conflict with suggested
name pattern), let's move to ZOOKEEPER-3507.
   
   For a proper line break strategy, or even we don't want it, let's discuss in ZOOKEEPER-3508.
   
   Log format issue is now tracked by ZOOKEEPER-3509.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message