zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] dineshappavoo commented on a change in pull request #1025: [ZOOKEEPER-3471] Fix potential lock unavailable due to dangling ephemeral nodes left during local session upgrading
Date Tue, 13 Aug 2019 00:10:41 GMT
dineshappavoo commented on a change in pull request #1025: [ZOOKEEPER-3471] Fix potential lock
unavailable due to dangling ephemeral nodes left during local session upgrading
URL: https://github.com/apache/zookeeper/pull/1025#discussion_r313177914
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
 ##########
 @@ -992,6 +990,7 @@ public void submitRequestNow(Request si) {
             touch(si.cnxn);
             boolean validpacket = Request.isValid(si.type);
             if (validpacket) {
+                setLocalSessionFlag(si);
 
 Review comment:
   Thanks @lvfangmin . I think I misunderstood. It was good to clarify and I checked little
deeper after that. Yes, now I understood all the requests go through `RequestThrottler`. 
   
   And the change looks good to me.  Thanks for fixing it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message