zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] enixon commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server
Date Mon, 12 Aug 2019 19:05:14 GMT
enixon commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration
on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r313081572
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServerMXBean.java
 ##########
 @@ -25,192 +25,233 @@
     /**
      * @return the server socket port number
      */
-    public String getClientPort();
+    String getClientPort();
+
     /**
      * @return the zookeeper server version
      */
-    public String getVersion();
+    String getVersion();
+
     /**
      * @return time the server was started
      */
-    public String getStartTime();
+    String getStartTime();
+
     /**
      * @return min request latency in ms
      */
-    public long getMinRequestLatency();
+    long getMinRequestLatency();
+
     /**
      * @return average request latency in ms
      */
-    public double getAvgRequestLatency();
+    double getAvgRequestLatency();
+
     /**
      * @return max request latency in ms
      */
-    public long getMaxRequestLatency();
+    long getMaxRequestLatency();
+
     /**
      * @return number of packets received so far
      */
-    public long getPacketsReceived();
+    long getPacketsReceived();
+
     /**
      * @return number of packets sent so far
      */
-    public long getPacketsSent();
+    long getPacketsSent();
+
     /**
      * @return number of fsync threshold exceeds so far
      */
-    public long getFsyncThresholdExceedCount();
+    long getFsyncThresholdExceedCount();
+
     /**
      * @return number of outstanding requests.
      */
-    public long getOutstandingRequests();
+    long getOutstandingRequests();
+
     /**
-     * Current TickTime of server in milliseconds
+     * Current TickTime of server in milliseconds.
      */
-    public int getTickTime();
+    int getTickTime();
+
     /**
-     * Set TickTime of server in milliseconds
+     * Set TickTime of server in milliseconds.
      */
-    public void setTickTime(int tickTime);
+    void setTickTime(int tickTime);
 
-    /** Current maxClientCnxns allowed from a particular host */
-    public int getMaxClientCnxnsPerHost();
+    /**
+     * Current maxClientCnxns allowed from a particular host.
+     */
+    int getMaxClientCnxnsPerHost();
 
-    /** Set maxClientCnxns allowed from a particular host */
-    public void setMaxClientCnxnsPerHost(int max);
+    /**
+     * Set maxClientCnxns allowed from a particular host.
+     */
+    void setMaxClientCnxnsPerHost(int max);
 
     /**
-     * Current minSessionTimeout of the server in milliseconds
+     * Current minSessionTimeout of the server in milliseconds.
      */
-    public int getMinSessionTimeout();
+    int getMinSessionTimeout();
+
     /**
-     * Set minSessionTimeout of server in milliseconds
+     * Set minSessionTimeout of server in milliseconds.
      */
-    public void setMinSessionTimeout(int min);
+    void setMinSessionTimeout(int min);
 
     /**
-     * Current maxSessionTimeout of the server in milliseconds
+     * Current maxSessionTimeout of the server in milliseconds.
      */
-    public int getMaxSessionTimeout();
+    int getMaxSessionTimeout();
+
     /**
-     * Set maxSessionTimeout of server in milliseconds
+     * Set maxSessionTimeout of server in milliseconds.
      */
-    public void setMaxSessionTimeout(int max);
+    void setMaxSessionTimeout(int max);
+
+    boolean getResponseCachingEnabled();
 
-    public boolean getResponseCachingEnabled();
-    public void setResponseCachingEnabled(boolean isEnabled);
+    void setResponseCachingEnabled(boolean isEnabled);
 
     /* Connection throttling settings */
-    public int getConnectionMaxTokens();
-    public void setConnectionMaxTokens(int val);
 
 Review comment:
   @nkalmar - looks like you're right that it is just getters/setters together. My mind was
probably on the groupings of ServerMetrics.
   
   I'm okay with keeping your change as it is, @TisonKun.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message