zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] hanm commented on issue #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server
Date Mon, 12 Aug 2019 18:19:44 GMT
hanm commented on issue #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#issuecomment-520538013
 
 
   I have my pass over this, and my feedback is it might be a good idea if we limit the type
of changes to be:
   * Pure formatting changes: white spaces, curly braces, indentations, etc.
   * None functional changes: remove unneeded imports, unused exceptions types, unneeded type
parameters, etc.
   
   This will provide a simpler conceptual mode to review and merge this patch with high confidence
that the impact will be limited. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message