zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] TisonKun edited a comment on issue #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server
Date Mon, 12 Aug 2019 10:46:59 GMT
TisonKun edited a comment on issue #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on
zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#issuecomment-520376969
 
 
   @enixon 
   
   > Do we know whether the change in visibility to some of the methods will effect curator
or other third parties?
   
   There is no refactoring and nothing public changed. Only reformatting and some dead code
deletion included. It is expected be unaware of any other third parties.
   
   > A question for others: with regards to the TODOs in the code, do we have any expectation
that they are backed by JIRA tickets and, if so, how can them be linked to the ticket number?
   
   Nice question. We could have another pass(whether or not coupled within this) to investigate
all TODOs and linked to the ticket and when there is no one, create one or delete TODO comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message