zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] enixon commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server
Date Sun, 11 Aug 2019 19:54:56 GMT
enixon commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration
on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r312751244
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/EphemeralType.java
 ##########
 @@ -188,24 +179,27 @@ public static EphemeralType get(long ephemeralOwner) {
     }
 
     /**
-     * Make sure the given server ID is compatible with the current extended ephemeral setting
+     * Make sure the given server ID is compatible with the current extended ephemeral setting.
      *
      * @param serverId Server ID
      * @throws RuntimeException extendedTypesEnabled is true but Server ID is too large
      */
     public static void validateServerId(long serverId) {
-        // TODO: in the future, serverId should be validated for all cases, not just the
extendedEphemeralTypesEnabled case
+        // TODO: in the future, serverId should be validated for all cases,
 
 Review comment:
   This is the kind of TODO that I'm wondering how the community tracks. In my perfect world,
each is accompanied by a comment like "ZK-156".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message