zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #1037: ZOOKEEPER-3492: Add weights to server side connection throttling
Date Fri, 09 Aug 2019 15:09:35 GMT
eolivelli commented on a change in pull request #1037: ZOOKEEPER-3492: Add weights to server
side connection throttling
URL: https://github.com/apache/zookeeper/pull/1037#discussion_r312524814
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
 ##########
 @@ -608,7 +610,11 @@ public synchronized void startup() {
         registerMetrics();
 
         setState(State.RUNNING);
+
         requestPathMetricsCollector.start();
+
+        localSessionEnabled = sessionTracker instanceof UpgradeableSessionTracker
 
 Review comment:
   this 'instanceof' looks like a 'code smell'
   what about adding a isLocalSessionsEnabled method to the base class (SessionTracker) with
a default return value of 'false' ?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message