zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] lvfangmin commented on a change in pull request #1025: [ZOOKEEPER-3471] Fix potential lock unavailable due to dangling ephemeral nodes left during local session upgrading
Date Thu, 08 Aug 2019 15:39:10 GMT
lvfangmin commented on a change in pull request #1025: [ZOOKEEPER-3471] Fix potential lock
unavailable due to dangling ephemeral nodes left during local session upgrading
URL: https://github.com/apache/zookeeper/pull/1025#discussion_r312105620
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
 ##########
 @@ -992,6 +990,7 @@ public void submitRequestNow(Request si) {
             touch(si.cnxn);
             boolean validpacket = Request.isValid(si.type);
             if (validpacket) {
+                setLocalSessionFlag(si);
 
 Review comment:
   I'm not quite sure I understand your question here, all the requests will go through RequestThrottler,
and then being put into RequestProcessor now.
   
   So no request will be put into RequestProcessor directly, right? Let me know if I didn't
get your question.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message