zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] symat edited a comment on issue #1040: ZOOKEEPER-3470: fix flaky LearnerMetricsTest
Date Tue, 06 Aug 2019 07:38:24 GMT
symat edited a comment on issue #1040: ZOOKEEPER-3470: fix flaky LearnerMetricsTest
URL: https://github.com/apache/zookeeper/pull/1040#issuecomment-518546606
 
 
   @maoling - sorry, my bad, I didn't notice you are working on this already. Now I see that
your PR was linked to the jira ticket... next time I will make sure to be more careful.
   
   > Do a clean up work in the tearDown(),Look at an example from PR-1024.
   
   Thanks, I forget that, just pushed it in a new commit
   
   > Increase the timeout to a larger numbers(30s) may be avoiding the flaky, I'am not
sure about this. After merged, we can observer whether this flaky test happens again.
   
   True, we will need to monitor it. It fixed the issue on my laptop (before the fix I got
the error in each 15-20 execution, now I haven't got it even after 150), but fixed timeout
values are always tricky in tests. However, in my executions the 0 latency values were causing
the most of the failings.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message