zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] hanm commented on a change in pull request #1034: Specify commitLogCount value using a system property
Date Mon, 05 Aug 2019 23:48:09 GMT
hanm commented on a change in pull request #1034: Specify commitLogCount value using a system
property
URL: https://github.com/apache/zookeeper/pull/1034#discussion_r310833214
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZKDatabase.java
 ##########
 @@ -86,7 +86,9 @@
     public static final double DEFAULT_SNAPSHOT_SIZE_FACTOR = 0.33;
     private double snapshotSizeFactor;
 
-    public static final int commitLogCount = 500;
+    public static final String COMMIT_LOG_COUNT = "zookeeper.commitLogCount";
 
 Review comment:
   nit: should document this in admin doc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message