zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] symat opened a new pull request #1040: ZOOKEEPER-3470: fix flaky LearnerMetricsTest
Date Mon, 05 Aug 2019 15:51:57 GMT
symat opened a new pull request #1040: ZOOKEEPER-3470: fix flaky LearnerMetricsTest
URL: https://github.com/apache/zookeeper/pull/1040
 
 
   This PR is about fixing the flaky unit test: `LearnerMetricsTest`. 
   The code changes are:
   - Replacing the `Thread.sleep(200)` with polling the metrics until the assertion succeed
or timeout (this seems help in some flaky scenario)
   - Fixing the `ZKTestCase.waitFor` method
   - We are also logging the 0 millisec latency values now on the server side. We calculate
these latency values between different hosts (as the difference between the server wall time
and the wall time in the request header), so 0 values are possible. And in case of unittests
(where all the hosts are using the same clock) it can happen relatively frequently. This situation
also caused some of the flakiness. In the previous implementation the 0 latency values were
not counted, so the assertion on these counters values were failing in the end of the testcase.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message