zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] xoiss edited a comment on issue #999: ZOOKEEPER-2891: Invalid processing of zookeeper_close for mutli-request
Date Fri, 02 Aug 2019 18:01:23 GMT
xoiss edited a comment on issue #999: ZOOKEEPER-2891: Invalid processing of zookeeper_close
for mutli-request
URL: https://github.com/apache/zookeeper/pull/999#issuecomment-517766454
 
 
   > @xoiss #1030 merged. Please rebase this one.
   
   rebased
   
   ----
   
   Hello!
   
   As it turned out, https://github.com/apache/zookeeper/pull/1030, https://github.com/apache/zookeeper/pull/717
(ZOOKEEPER-1636) is 100% enough to close ZOOKEEPER-2891 also.
   
   And as soon as https://github.com/apache/zookeeper/pull/1030, https://github.com/apache/zookeeper/pull/717
cover the more common case (general "unsuccessful status", but not only ZCLOSING), and https://github.com/apache/zookeeper/pull/717
is already in the `master` -- surely, I would prefer to **withdraw** my solution in this PR
in flavour of that one in https://github.com/apache/zookeeper/pull/1030 https://github.com/apache/zookeeper/pull/717.
   
   // Many thanks to @mkedwards for his idea given in https://github.com/apache/zookeeper/pull/717
!
   
   Hence, **there are two unit-tests proposed in this PR**. If you wish, we can merge them
into `branch-3.4`, `branch-3.5` and `master`. If it's necessary, I can open a dedicated PR
for them. What do you think?
   
   // I've edited this PR. Namely, I've removed patches to the Client code, but left only
two unit-tests. So, **this PR now contains only unit-tests**.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message