zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] lvfangmin commented on a change in pull request #1007: ZOOKEEPER-3448: Introduce MessageTracker to assist debug leader and leaner connectivity issues.
Date Thu, 01 Aug 2019 05:55:49 GMT
lvfangmin commented on a change in pull request #1007: ZOOKEEPER-3448: Introduce MessageTracker
to assist debug leader and leaner connectivity issues.
URL: https://github.com/apache/zookeeper/pull/1007#discussion_r309532603
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
 ##########
 @@ -271,6 +280,8 @@ protected void setBufferedOutput(BufferedOutputStream bufferedOutput)
{
             }
             throw new SaslException("Authentication failure: " + e.getMessage());
         }
+
+        this.messageTracker = new MessageTracker(BUFFERED_MESSAGE_SIZE);
 
 Review comment:
   @hanm I understand the logging part is low cost, but add/remove all the packets in the
synchronized FIFO CircularBuffer is not trivial on high traffic environment, that's why I
concerned about the performance.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message