From notifications-return-960-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Sun Jul 28 19:48:40 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 62334180671 for ; Sun, 28 Jul 2019 21:48:40 +0200 (CEST) Received: (qmail 31189 invoked by uid 500); 28 Jul 2019 19:48:39 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 31180 invoked by uid 99); 28 Jul 2019 19:48:39 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 28 Jul 2019 19:48:39 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] lvfangmin commented on a change in pull request #632: [ZOOKEEPER-3150] Add tree digest check and verify data integrity when loading from disk Message-ID: <156434331978.7795.12751272653227712444.gitbox@gitbox.apache.org> Date: Sun, 28 Jul 2019 19:48:39 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit lvfangmin commented on a change in pull request #632: [ZOOKEEPER-3150] Add tree digest check and verify data integrity when loading from disk URL: https://github.com/apache/zookeeper/pull/632#discussion_r308015358 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java ########## @@ -39,6 +40,8 @@ import org.apache.zookeeper.data.ACL; import org.apache.zookeeper.data.Stat; import org.apache.zookeeper.data.StatPersisted; +import org.apache.zookeeper.server.ServerMetrics; Review comment: It's being used in reportDigestMismatch, but I think I can remove the import here, since it's in the same package. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services