From notifications-return-956-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Sun Jul 28 18:25:35 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 19208180671 for ; Sun, 28 Jul 2019 20:25:35 +0200 (CEST) Received: (qmail 71652 invoked by uid 500); 28 Jul 2019 18:25:34 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 71643 invoked by uid 99); 28 Jul 2019 18:25:34 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 28 Jul 2019 18:25:34 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] lvfangmin opened a new pull request #1026: [ZOOKEEPER-3472] Treat check request as a write request which needs to wait for the check txn commit from leader Message-ID: <156433833439.3975.1481888279742021152.gitbox@gitbox.apache.org> Date: Sun, 28 Jul 2019 18:25:34 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit lvfangmin opened a new pull request #1026: [ZOOKEEPER-3472] Treat check request as a write request which needs to wait for the check txn commit from leader URL: https://github.com/apache/zookeeper/pull/1026 Check op is usually used as a sub op in multi, but from the ZooKeeper server implementation it can also called separately, the learner will forward this request to leader, and the leader will check the version with the given version in the request, and generate a txn (error) in the quorum. There is no explicit API exposed for check, but it could leave an issue there if the check API is exposed in the future. Also because the check API is not exposed, we cannot write an E2E test for check here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services