From notifications-return-801-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon Jul 22 19:29:53 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7E04418064F for ; Mon, 22 Jul 2019 21:29:53 +0200 (CEST) Received: (qmail 39408 invoked by uid 500); 22 Jul 2019 19:29:52 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 39384 invoked by uid 99); 22 Jul 2019 19:29:52 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Jul 2019 19:29:52 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] lvfangmin commented on a change in pull request #919: ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback from ZK Message-ID: <156382379264.9990.7022398877343373414.gitbox@gitbox.apache.org> Date: Mon, 22 Jul 2019 19:29:52 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit lvfangmin commented on a change in pull request #919: ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback from ZK URL: https://github.com/apache/zookeeper/pull/919#discussion_r305995160 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java ########## @@ -378,8 +411,33 @@ public void operationComplete(Future future) { } } } + + @Sharable + static class ReadIssuedTrackingHandler extends ChannelDuplexHandler { + Review comment: Currently, there is only a single instance of ReadIssuedTrackingHandler created in NettyServerCnxnFactory, and there is only a single instance of NettyServerCnxnFactory per JVM lifecycle, so ReadIssuedTrackingHandler is only 1 instance per JVM. Personally, I don't see there is value to create a static instance in ReadIssuedTrackingHandler, I'll keep the current implementation here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services