From notifications-return-728-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Jul 12 23:30:37 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C91811802C7 for ; Sat, 13 Jul 2019 01:30:36 +0200 (CEST) Received: (qmail 51152 invoked by uid 500); 12 Jul 2019 23:30:36 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 51143 invoked by uid 99); 12 Jul 2019 23:30:36 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Jul 2019 23:30:36 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] ericlee123 commented on a change in pull request #924: ZOOKEEPER-3371: Port unification for Jetty admin server Message-ID: <156297423612.21044.2582576970410323282.gitbox@gitbox.apache.org> Date: Fri, 12 Jul 2019 23:30:36 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ericlee123 commented on a change in pull request #924: ZOOKEEPER-3371: Port unification for Jetty admin server URL: https://github.com/apache/zookeeper/pull/924#discussion_r303176943 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/ReadAheadEndpoint.java ########## @@ -74,7 +74,10 @@ public ReadAheadEndpoint(final EndPoint channel, final int readAheadLength){ private synchronized void readAhead() throws IOException { if (leftToRead > 0) { - final int n = endPoint.fill(start); + int n = 0; Review comment: I discovered in my changes when cleaning things up. I was running into the situation where data a TLS connection wasn't ready to be read (`fill()`). Probably because secure connections have a bigger overhead, `JettyAdminServerTest` would only fail for secure connections (the plaintext connections would work fine). My idea here is to wait until the data is ready to be read, but as I am not an expert with Jetty `EndPoint`, these lines seems to have potential to infinitely loop. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services