From notifications-return-620-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Jul 2 20:00:00 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4617518060E for ; Tue, 2 Jul 2019 22:00:00 +0200 (CEST) Received: (qmail 64491 invoked by uid 500); 2 Jul 2019 19:59:59 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 64482 invoked by uid 99); 2 Jul 2019 19:59:59 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jul 2019 19:59:59 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] jorgheymans commented on a change in pull request #1002: ZOOKEEPER-3453:zkcli.cmd: ZOO_LOG_FILE is missing set Message-ID: <156209759958.6318.6177139140523270150.gitbox@gitbox.apache.org> Date: Tue, 02 Jul 2019 19:59:59 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit jorgheymans commented on a change in pull request #1002: ZOOKEEPER-3453:zkcli.cmd: ZOO_LOG_FILE is missing set URL: https://github.com/apache/zookeeper/pull/1002#discussion_r299660131 ########## File path: bin/zkEnv.cmd ########## @@ -46,5 +46,8 @@ if not exist "%JAVA_HOME%"\bin\java.exe ( goto :eof ) +REM strip off trailing \ from JAVA_HOME or java does not start +if "%JAVA_HOME:~-1%" EQU "\" set "JAVA_HOME=%JAVA_HOME:~0,-1%" + set JAVA="%JAVA_HOME%"\bin\java Review comment: i reverted the obsolete commit from the PR ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services