From notifications-return-614-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Jul 2 18:12:26 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 05FC2180763 for ; Tue, 2 Jul 2019 20:12:25 +0200 (CEST) Received: (qmail 94006 invoked by uid 500); 2 Jul 2019 18:12:25 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 93997 invoked by uid 99); 2 Jul 2019 18:12:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jul 2019 18:12:25 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bzookeeper=5D_enixon_commented_on_a_change_in_pu?= =?utf-8?q?ll_request_=23972=3A_ZOOKEEPER-2418=3A_txnlog_diff_sync_can_ski?= =?utf-8?q?p_sending_some_transactions_t=E2=80=A6?= Message-ID: <156209114205.17016.3263639274575944567.gitbox@gitbox.apache.org> Date: Tue, 02 Jul 2019 18:12:22 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit enixon commented on a change in pull request #972: ZOOKEEPER-2418: txnlog diff sync can skip sending some transactions t… URL: https://github.com/apache/zookeeper/pull/972#discussion_r299614225 ########## File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerHandlerTest.java ########## @@ -487,60 +487,6 @@ public void testNewEpochZxid() throws Exception { } - /** - * Test cases when learner has new-epcoh zxid - * (zxid & 0xffffffffL) == 0; - */ - @Test - public void testNewEpochZxidWithTxnlogOnly() throws Exception { Review comment: The structure of this test requires inserting gaps in the txn log in order to work, indeed it is testing what response the learner gets when it has a gap. There's no way to rescue the test after this PR adds protection against syncing on top of such a gap so I'm dropping it (in favor of adding the test farther below that tests behavior on a gap directly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services