From notifications-return-604-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Jul 2 16:13:45 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9CC9018060E for ; Tue, 2 Jul 2019 18:13:45 +0200 (CEST) Received: (qmail 43033 invoked by uid 500); 2 Jul 2019 16:13:45 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 43023 invoked by uid 99); 2 Jul 2019 16:13:45 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jul 2019 16:13:45 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] hanm commented on a change in pull request #1007: ZOOKEEPER-3448: Introduce MessageTracker to assist debug leader and leaner connectivity issues. Message-ID: <156208402493.14133.1440327970607758080.gitbox@gitbox.apache.org> Date: Tue, 02 Jul 2019 16:13:44 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit hanm commented on a change in pull request #1007: ZOOKEEPER-3448: Introduce MessageTracker to assist debug leader and leaner connectivity issues. URL: https://github.com/apache/zookeeper/pull/1007#discussion_r299567658 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java ########## @@ -192,6 +194,9 @@ public boolean equals(Object o) { private final BufferedInputStream bufferedInput; private BufferedOutputStream bufferedOutput; + private static final int BUFFERED_MESSAGE_SIZE = 10; Review comment: The current default value is somehow arbitrary chosen and works for us but I agree this should be tunable. Will make the change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services