zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] hanm commented on a change in pull request #632: [ZOOKEEPER-3150] Add tree digest check and verify data integrity when loading from disk
Date Sat, 27 Jul 2019 23:47:35 GMT
hanm commented on a change in pull request #632: [ZOOKEEPER-3150] Add tree digest check and
verify data integrity when loading from disk
URL: https://github.com/apache/zookeeper/pull/632#discussion_r307979771
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/util/DigestCalculator.java
 ##########
 @@ -0,0 +1,145 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server.util;
+
+import java.nio.ByteBuffer;
+import java.util.zip.CRC32;
+
+import org.apache.zookeeper.ZooDefs;
+import org.apache.zookeeper.data.StatPersisted;
+import org.apache.zookeeper.server.DataNode;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Defines how to calculate the digest for a given node.
+ */
+public class DigestCalculator {
+
+    private static final Logger LOG = LoggerFactory.getLogger(DigestCalculator.class);
+
+    // The hardcoded digest version, should bump up this version whenever
+    // we changed the digest method or fields.
+    //
+    // Defined it as Integer to make it able to be changed in test via reflection
+    public static final Integer DIGEST_VERSION = 2;
+
+    public static final String ZOOKEEPER_DIGEST_ENABLED = "zookeeper.digest.enabled";
+    private static boolean digestEnabled = true;
 
 Review comment:
   nit: remove `= true` as this will be assigned anyway in the following static block.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message