zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #989: ZOOKEEPER-3430: Observability improvement: provide top N read / write path queries.
Date Fri, 26 Jul 2019 21:52:17 GMT
eolivelli commented on a change in pull request #989: ZOOKEEPER-3430: Observability improvement:
provide top N read / write path queries.
URL: https://github.com/apache/zookeeper/pull/989#discussion_r307919858
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
 ##########
 @@ -200,6 +202,7 @@ void removeCnxn(ServerCnxn cnxn) {
     public ZooKeeperServer() {
         listener = new ZooKeeperServerListenerImpl(this);
         serverStats = new ServerStats(this);
+        this.requestPathMetricsCollector = new RequestPathMetricsCollector();
 
 Review comment:
   what about having a default no-op implementation of RequestPathMetricsCollector and make
this feature disabled by default ?
   it would consume CPU cycles even if not needed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message