zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] TisonKun commented on a change in pull request #1023: ZOOKEEPER-3468: Enable BookKeeper checkstyle configuration on zookeeper-jute
Date Thu, 25 Jul 2019 12:03:36 GMT
TisonKun commented on a change in pull request #1023: ZOOKEEPER-3468: Enable BookKeeper checkstyle
configuration on zookeeper-jute
URL: https://github.com/apache/zookeeper/pull/1023#discussion_r307127785
 
 

 ##########
 File path: zookeeper-jute/src/main/java/org/apache/jute/BinaryInputArchive.java
 ##########
 @@ -22,108 +22,124 @@
 import java.io.DataInputStream;
 import java.io.IOException;
 import java.io.InputStream;
+import java.nio.charset.StandardCharsets;
 
 /**
  *
 
 Review comment:
   Otherwise we can enable it in this pass and set javadoc placeholder. Now I think it would
be better and update accrodingly

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message