zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] maoling commented on issue #1019: ZOOKEEPER-3464:enfore checkstyle in the zookeeper-server module and clean the package:admin and client
Date Wed, 24 Jul 2019 08:50:01 GMT
maoling commented on issue #1019: ZOOKEEPER-3464:enfore checkstyle in the zookeeper-server
module and clean the package:admin and client
URL: https://github.com/apache/zookeeper/pull/1019#issuecomment-514541169
 
 
   @TisonKun 
   
   - > add a configuration file and enable it on zookeeper-server. As discussed in mailing
list we would at first add a configuration and then enable it per pkg so there is ZOOKEEPER-3465
   
   - It's reasonable, but mixing them will not give us too much code review burden.The most
important is:adding and enabling the configuration file without picking a package to do the
experimental cleaning work will not give me the insight and check/confirm what the things
I'am doing is correct.
   
   - > Could you explain where rules in checkstyleSuppressions-strict.xml comes from?
   
   - every package under the `zookeeper-server `is a suppressions statement, but the 37 java
files under that module in the first level is difficult to write the suppressions regex and
their codes are so long and many, many violates, so I split them into the specify java files
for the CR easily in the future.
   - > If we follow the process above, we could just enable it per package and there should
be no suppression config needed.
   
   - I only know the suppression way, how to enable it per package? plz tell me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message