zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] maoling commented on a change in pull request #1019: ZOOKEEPER-3464:enfore checkstyle in the zookeeper-server module and clean the package:admin and client
Date Wed, 24 Jul 2019 08:04:50 GMT
maoling commented on a change in pull request #1019: ZOOKEEPER-3464:enfore checkstyle in the
zookeeper-server module and clean the package:admin and client
URL: https://github.com/apache/zookeeper/pull/1019#discussion_r306677567
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -582,19 +582,20 @@
               <version>${checkstyle.version}</version>
             </dependency>
           </dependencies>
-          <configuration>
-            <configLocation>checkstyle.xml</configLocation>
-            <suppressionsLocation>checkstyleSuppressions.xml</suppressionsLocation>
-            <encoding>UTF-8</encoding>
-            <consoleOutput>true</consoleOutput>
-            <failOnViolation>true</failOnViolation>
-            <includeResources>false</includeResources>
-            <includeTestSourceDirectory>true</includeTestSourceDirectory>
-          </configuration>
           <executions>
             <execution>
               <id>checkstyle</id>
               <phase>validate</phase>
+              <configuration>
+                <configLocation>checkstyle.xml</configLocation>
 
 Review comment:
   - @TisonKun  Thanks for the notice.
   - I check the rule for the "the '@author' tag" 
   
   > <module name="TodoComment">
               <!-- Checks that disallowed strings are not used in comments.  -->
               <property name="format" value="(@author)" />
           </module>
   
   and found it doesn't work.search around and don't find a valid way to enforce no `author`
tag in the javaDoc.Cc @eolivelli 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message