zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] jhuan31 commented on a change in pull request #995: ZOOKEEPER-3437: Improve sync throttling on a learner master
Date Wed, 24 Jul 2019 04:27:55 GMT
jhuan31 commented on a change in pull request #995: ZOOKEEPER-3437: Improve sync throttling
on a learner master
URL: https://github.com/apache/zookeeper/pull/995#discussion_r306623066
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
 ##########
 @@ -603,6 +612,9 @@ public void run() {
             learnerMaster.waitForNewLeaderAck(getSid(), qp.getZxid());
 
             syncLimitCheck.start();
+            // sync ends when NEWLEADER-ACK is received
+            syncThrottler.endSync();
 
 Review comment:
   endSync() is called in the finally block line 720-722, if not called earlier. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message