zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #995: ZOOKEEPER-3437: Improve sync throttling on a learner master
Date Tue, 23 Jul 2019 05:15:17 GMT
eolivelli commented on a change in pull request #995: ZOOKEEPER-3437: Improve sync throttling
on a learner master
URL: https://github.com/apache/zookeeper/pull/995#discussion_r306128857
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
 ##########
 @@ -603,6 +612,9 @@ public void run() {
             learnerMaster.waitForNewLeaderAck(getSid(), qp.getZxid());
 
             syncLimitCheck.start();
+            // sync ends when NEWLEADER-ACK is received
+            syncThrottler.endSync();
 
 Review comment:
   Is this endSync() call to be put in a finally block?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message