zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] hanm commented on a change in pull request #1007: ZOOKEEPER-3448: Introduce MessageTracker to assist debug leader and leaner connectivity issues.
Date Tue, 23 Jul 2019 01:15:53 GMT
hanm commented on a change in pull request #1007: ZOOKEEPER-3448: Introduce MessageTracker
to assist debug leader and leaner connectivity issues.
URL: https://github.com/apache/zookeeper/pull/1007#discussion_r306094033
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
 ##########
 @@ -271,6 +280,8 @@ protected void setBufferedOutput(BufferedOutputStream bufferedOutput)
{
             }
             throw new SaslException("Authentication failure: " + e.getMessage());
         }
+
+        this.messageTracker = new MessageTracker(BUFFERED_MESSAGE_SIZE);
 
 Review comment:
   @lvfangmin On perf side, the recorded messages are bounded and the log will only be dumped
when server disconnects, so the impact on performance would be negligible. That said, I think
it's very reasonable to request a feature flag here. I'll add an option which by default turns
all instrumentation and log dump into no-ops after I rebase this PR with latest master.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message