zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] hanm commented on a change in pull request #905: ZOOKEEPER-3359: Batch commits in the CommitProcessor
Date Wed, 17 Jul 2019 23:53:47 GMT
hanm commented on a change in pull request #905:  ZOOKEEPER-3359: Batch commits in the CommitProcessor

URL: https://github.com/apache/zookeeper/pull/905#discussion_r304597882
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/CommitProcessor.java
 ##########
 @@ -409,6 +470,66 @@ private void sendToNextProcessor(Request request) {
         workerPool.schedule(new CommitWorkRequest(request), request.sessionId);
     }
 
+    private void processWrite(Request request) throws RequestProcessorException {
+        if (request.commitProcQueueStartTime != -1 &&
 
 Review comment:
   L474 to L486 is an exact copy of the same code in `doWork`, could we refactor these copied
code to a common function, or alternatively, let `doWork` call `processWrite`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message