zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] ericlee123 commented on a change in pull request #924: ZOOKEEPER-3371: Port unification for Jetty admin server
Date Fri, 12 Jul 2019 23:30:36 GMT
ericlee123 commented on a change in pull request #924: ZOOKEEPER-3371: Port unification for
Jetty admin server
URL: https://github.com/apache/zookeeper/pull/924#discussion_r303176943
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/ReadAheadEndpoint.java
 ##########
 @@ -74,7 +74,10 @@ public ReadAheadEndpoint(final EndPoint channel, final int readAheadLength){
 
     private synchronized void readAhead() throws IOException {
         if (leftToRead > 0) {
-            final int n = endPoint.fill(start);
+            int n = 0;
 
 Review comment:
   I discovered in my changes when cleaning things up. I was running into the situation where
data a TLS connection wasn't ready to be read (`fill()`). Probably because secure connections
have a bigger overhead, `JettyAdminServerTest` would only fail for secure connections (the
plaintext connections would work fine). My idea here is to wait until the data is ready to
be read, but as I am not an expert with Jetty `EndPoint`, these lines seems to have potential
to infinitely loop.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message