zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #1012: ZOOKEEPER-3459: Add admin command to display synced state of peer
Date Tue, 09 Jul 2019 22:06:19 GMT
eolivelli commented on a change in pull request #1012: ZOOKEEPER-3459: Add admin command to
display synced state of peer
URL: https://github.com/apache/zookeeper/pull/1012#discussion_r301813674
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
 ##########
 @@ -778,6 +817,15 @@ public long getLeaderId() {
         return leaderId.get();
     }
 
+
+    public String getDetailedPeerState() {
+        return getPeerState().toString().toLowerCase()
+                + ((getZabState() != ZabState.ELECTION) ?
 
 Review comment:
   Nit: isn't it better to call only once getZabState and getSyncMode ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message