zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] maoling commented on a change in pull request #992: ZOOKEEPER-3434:[FileTabCharacter] clear up the all the checkstyle violations in the zookeeper-server module
Date Tue, 09 Jul 2019 11:25:00 GMT
maoling commented on a change in pull request #992: ZOOKEEPER-3434:[FileTabCharacter] clear
up the all the checkstyle violations in the zookeeper-server module
URL: https://github.com/apache/zookeeper/pull/992#discussion_r301533392
 
 

 ##########
 File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/Zab1_0Test.java
 ##########
 @@ -554,36 +554,41 @@ public void converseWithLeader(InputArchive ia, OutputArchive oa,
             }
         }, 2);
     }
-    
+
     // We want to track the change with a callback rather than depending on timing
     class TrackerWatcher implements Watcher {
         boolean changed;
+
         synchronized void waitForChange() throws InterruptedException {
-            while(!changed) {
+            while (!changed) {
                 wait();
             }
         }
+
         @Override
         public void process(WatchedEvent event) {
             if (event.getType() == EventType.NodeDataChanged) {
-                synchronized(this) {
+                synchronized (this) {
                     changed = true;
                     notifyAll();
                 }
             }
         }
+
         synchronized public boolean changed() {
             return changed;
         }
 
-    };
-    
+    }
+
+    ;
 
 Review comment:
   @anmolnar  this PR will be redone for not obeying the way we discuss in the email thread

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message