zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] mayawang commented on a change in pull request #995: ZOOKEEPER-3437: Improve sync throttling on a learner master
Date Tue, 09 Jul 2019 02:18:38 GMT
mayawang commented on a change in pull request #995: ZOOKEEPER-3437: Improve sync throttling
on a learner master
URL: https://github.com/apache/zookeeper/pull/995#discussion_r301371370
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerMaster.java
 ##########
 @@ -29,18 +31,81 @@
 /**
  * interface for keeping Observers in sync
  */
-public interface LearnerMaster {
+public abstract class LearnerMaster {
+    private static final Logger LOG = LoggerFactory.getLogger(LearnerMaster.class);
+
+    // Throttle when there are too many concurrent snapshots being sent to observers
+    private static final String MAX_CONCURRENT_SNAPSYNCS = "zookeeper.leader.maxConcurrentSnapSyncs";
 
 Review comment:
   Thanks for the details! I think we can keep this configuration just one parameter for now.
I'd love to learn the actual system behavior once this is used in production.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message