zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] hanm commented on a change in pull request #995: ZOOKEEPER-3437: Improve sync throttling on a learner master
Date Wed, 03 Jul 2019 23:55:43 GMT
hanm commented on a change in pull request #995: ZOOKEEPER-3437: Improve sync throttling on
a learner master
URL: https://github.com/apache/zookeeper/pull/995#discussion_r300189132
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
 ##########
 @@ -505,34 +510,35 @@ public void run() {
             // startForwarding() will be called in all cases
             boolean needSnap = syncFollower(peerLastZxid, learnerMaster);
 
+            boolean exemptFromThrottle = getLearnerType() != LearnerType.OBSERVER;
 
 Review comment:
   I think it'll be good to add a comment here what exempt means (sync throttler will not
throttle if it's true) and why we need it (IIUC, we want the quorum servers to always sync
and ignore throttling because it's important to keep the state of quorum serves up to date
with leader). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message