zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] jorgheymans commented on a change in pull request #1002: zkcli.cmd: ZOO_LOG_FILE is missing set
Date Tue, 02 Jul 2019 07:55:55 GMT
jorgheymans commented on a change in pull request #1002: zkcli.cmd: ZOO_LOG_FILE is missing
set
URL: https://github.com/apache/zookeeper/pull/1002#discussion_r299347937
 
 

 ##########
 File path: bin/zkEnv.cmd
 ##########
 @@ -46,5 +46,8 @@ if not exist "%JAVA_HOME%"\bin\java.exe (
   goto :eof
 )
 
+REM strip off trailing \ from JAVA_HOME or java does not start
+if "%JAVA_HOME:~-1%" EQU "\" set "JAVA_HOME=%JAVA_HOME:~0,-1%"
+ 
 set JAVA="%JAVA_HOME%"\bin\java
 
 
 Review comment:
   apologies yes i had not sync'ed my fork. Would you like me to create a different PR or
is ok ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message