zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] jhuan31 commented on a change in pull request #995: ZOOKEEPER-3437: Improve sync throttling on a learner master
Date Mon, 01 Jul 2019 22:34:38 GMT
jhuan31 commented on a change in pull request #995: ZOOKEEPER-3437: Improve sync throttling
on a learner master
URL: https://github.com/apache/zookeeper/pull/995#discussion_r299242159
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerMaster.java
 ##########
 @@ -29,18 +31,81 @@
 /**
  * interface for keeping Observers in sync
  */
-public interface LearnerMaster {
+public abstract class LearnerMaster {
+    private static final Logger LOG = LoggerFactory.getLogger(LearnerMaster.class);
+
+    // Throttle when there are too many concurrent snapshots being sent to observers
+    private static final String MAX_CONCURRENT_SNAPSYNCS = "zookeeper.leader.maxConcurrentSnapSyncs";
 
 Review comment:
   The thing is, we don't know what the appropriate thresholds are until we roll the feature
out and then tune the settings.  If it turns out that we do need different settings for Leader
and ObserverMaster, we can add it, instead of introducing a setting that might never be used.
What do you think? (BTW, in our deployment, Leader and Followers can be in different data
centers too.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message