zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] jhuan31 commented on a change in pull request #986: ZOOKEEPER-3243: Add server-side request throttling
Date Mon, 01 Jul 2019 17:54:09 GMT
jhuan31 commented on a change in pull request #986: ZOOKEEPER-3243: Add server-side request
throttling
URL: https://github.com/apache/zookeeper/pull/986#discussion_r299153760
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
 ##########
 @@ -250,11 +263,20 @@ public ZooKeeperServer(JvmPauseMonitor jvmPauseMonitor, FileTxnSnapLog
txnLogFac
                            ZKDatabase zkDb, String initialConfig) {
         this(txnLogFactory, tickTime, minSessionTimeout, maxSessionTimeout, clientPortListenBacklog,
zkDb, initialConfig);
         this.jvmPauseMonitor = jvmPauseMonitor;
-        if(jvmPauseMonitor != null) {
+        if (jvmPauseMonitor != null) {
             LOG.info("Added JvmPauseMonitor to server");
         }
     }
 
+    static boolean getBooleanProp(String name, boolean def) {
 
 Review comment:
   it is not equivalent when we want the default to be true. But you are right that we don't
need this helper function. Replacing it with Boolean.parseBoolean(System.getProperty())

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message