From notifications-return-470-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Jun 25 22:04:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 75EA118062F for ; Wed, 26 Jun 2019 00:04:05 +0200 (CEST) Received: (qmail 87090 invoked by uid 500); 25 Jun 2019 22:04:05 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 87081 invoked by uid 99); 25 Jun 2019 22:04:04 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Jun 2019 22:04:04 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] lvfangmin commented on a change in pull request #919: ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback from ZK Message-ID: <156150024485.6608.6489663449493890938.gitbox@gitbox.apache.org> Date: Tue, 25 Jun 2019 22:04:04 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit lvfangmin commented on a change in pull request #919: ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback from ZK URL: https://github.com/apache/zookeeper/pull/919#discussion_r297412877 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java ########## @@ -378,8 +411,33 @@ public void operationComplete(Future future) { } } } + + @Sharable + static class ReadIssuedTrackingHandler extends ChannelDuplexHandler { + Review comment: That's what it is doing now, in the current code, there is only a single instance. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services