From notifications-return-395-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Sat Jun 22 04:28:12 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 425AA18076D for ; Sat, 22 Jun 2019 06:28:11 +0200 (CEST) Received: (qmail 2712 invoked by uid 500); 22 Jun 2019 04:28:10 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 2459 invoked by uid 99); 22 Jun 2019 04:28:09 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Jun 2019 04:28:09 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] hanm commented on a change in pull request #986: ZOOKEEPER-3243: Add server-side request throttling Message-ID: <156117768948.4416.2299887036836648326.gitbox@gitbox.apache.org> Date: Sat, 22 Jun 2019 04:28:09 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit hanm commented on a change in pull request #986: ZOOKEEPER-3243: Add server-side request throttling URL: https://github.com/apache/zookeeper/pull/986#discussion_r296433245 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxn.java ########## @@ -229,6 +243,19 @@ public void setStale() { stale = true; } + public boolean isInvalid() { + return invalid; + } + + public void setInvalid() { + if (!invalid) { + if (!stale) { Review comment: see my comments above on the stale checking... might worth considering close regardless of stale or not (not feeling strong about this, as i can't prove anything here). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services