From notifications-return-329-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Jun 18 06:46:58 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 36CD218066B for ; Tue, 18 Jun 2019 08:46:58 +0200 (CEST) Received: (qmail 53411 invoked by uid 500); 18 Jun 2019 06:46:57 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 53402 invoked by uid 99); 18 Jun 2019 06:46:57 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Jun 2019 06:46:57 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] eolivelli commented on a change in pull request #980: ZOOKEEPER-3423:use the maven-like way to ignore the generated version java files and doc the cmd:'./zkServer.sh version' Message-ID: <156084041748.15952.15720326582795599199.gitbox@gitbox.apache.org> Date: Tue, 18 Jun 2019 06:46:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit eolivelli commented on a change in pull request #980: ZOOKEEPER-3423:use the maven-like way to ignore the generated version java files and doc the cmd:'./zkServer.sh version' URL: https://github.com/apache/zookeeper/pull/980#discussion_r294630466 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/version/util/VerGen.java ########## @@ -198,7 +198,7 @@ public static void main(String[] args) { } else { rev = rev.trim(); } - generateFile(new File("."), version, rev, args[2]); + generateFile(new File("../../../target/generated-sources/java"), version, rev, args[2]); Review comment: It is better to have this path passed as a parameter, this way it will be easier to drive this code from the pom.xml ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services