From notifications-return-44-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Sun Jun 2 21:08:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 770C718064E for ; Sun, 2 Jun 2019 23:08:01 +0200 (CEST) Received: (qmail 12007 invoked by uid 500); 2 Jun 2019 21:07:57 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 11998 invoked by uid 99); 2 Jun 2019 21:07:57 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Jun 2019 21:07:57 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider Message-ID: <155950967388.27622.523238138556906518.gitbox@gitbox.apache.org> Date: Sun, 02 Jun 2019 21:07:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider URL: https://github.com/apache/zookeeper/pull/918#issuecomment-498065598 Thank you @nkalmar ! It would be great to have your final approval @lvfangmin :-) I will commit tomorrow. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services