zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #1007: ZOOKEEPER-3448: Introduce MessageTracker to assist debug leader and leaner connectivity issues.
Date Sun, 30 Jun 2019 12:07:28 GMT
eolivelli commented on a change in pull request #1007: ZOOKEEPER-3448: Introduce MessageTracker
to assist debug leader and leaner connectivity issues.
URL: https://github.com/apache/zookeeper/pull/1007#discussion_r298831108
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
 ##########
 @@ -192,6 +194,9 @@ public boolean equals(Object o) {
     private final BufferedInputStream bufferedInput;
     private BufferedOutputStream bufferedOutput;
 
+    private static final int BUFFERED_MESSAGE_SIZE = 10;
 
 Review comment:
   Did you consider to make this tunable?
   I am fine to have it NOT tunable.
   How did you choose 10 as magic number?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message