zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] hanm commented on a change in pull request #972: ZOOKEEPER-2418: txnlog diff sync can skip sending some transactions t…
Date Fri, 28 Jun 2019 23:42:57 GMT
hanm commented on a change in pull request #972: ZOOKEEPER-2418: txnlog diff sync can skip
sending some transactions t…
URL: https://github.com/apache/zookeeper/pull/972#discussion_r298775859
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
 ##########
 @@ -820,11 +820,25 @@ boolean syncFollower(long peerLastZxid, LearnerMaster learnerMaster)
{
                     currentZxid = queueCommittedProposals(txnLogItr, peerLastZxid,
                                                          minCommittedLog, maxCommittedLog);
 
-                    LOG.debug("Queueing committedLog 0x" + Long.toHexString(currentZxid));
-                    Iterator<Proposal> committedLogItr = db.getCommittedLog().iterator();
-                    currentZxid = queueCommittedProposals(committedLogItr, currentZxid,
-                                                         null, maxCommittedLog);
-                    needSnap = false;
+                    if (currentZxid < minCommittedLog) {
+                        LOG.info("Detected gap between end of txnlog: " +
 
 Review comment:
   On the other side, since this clearly fix a correctness issue in current code, I am +1
on land this if we don't have better trade off to make here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message