zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] ivanyu commented on a change in pull request #1003: ZOOKEEPER-3443: Add support of PKCS12 trust/key stores
Date Wed, 26 Jun 2019 11:04:47 GMT
ivanyu commented on a change in pull request #1003: ZOOKEEPER-3443: Add support of PKCS12 trust/key
stores
URL: https://github.com/apache/zookeeper/pull/1003#discussion_r297607480
 
 

 ##########
 File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/X509TestContext.java
 ##########
 @@ -214,6 +219,28 @@ private File getTrustStorePemFile() throws IOException {
         return trustStorePemFile;
     }
 
+    private File getTrustStorePkcs12File() throws IOException {
+        if (trustStorePkcs12File == null) {
+            try {
+                File trustStorePkcs12File = File.createTempFile(
+                    TRUST_STORE_PREFIX, KeyStoreFileType.PKCS12.getDefaultFileExtension(),
tempDir);
+                trustStorePkcs12File.deleteOnExit();
+                final FileOutputStream trustStoreOutputStream = new FileOutputStream(trustStorePkcs12File);
 
 Review comment:
   Done in this file. Also checked other files, all except for `StandardTypeFileKeyStoreLoader`,
which is being discussed https://github.com/apache/zookeeper/pull/1003#discussion_r297314763

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message