zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] maoling commented on a change in pull request #1002: zkcli.cmd: ZOO_LOG_FILE is missing set
Date Wed, 26 Jun 2019 03:58:27 GMT
maoling commented on a change in pull request #1002: zkcli.cmd: ZOO_LOG_FILE is missing set
URL: https://github.com/apache/zookeeper/pull/1002#discussion_r297475217
 
 

 ##########
 File path: bin/zkEnv.cmd
 ##########
 @@ -46,5 +46,8 @@ if not exist "%JAVA_HOME%"\bin\java.exe (
   goto :eof
 )
 
+REM strip off trailing \ from JAVA_HOME or java does not start
+if "%JAVA_HOME:~-1%" EQU "\" set "JAVA_HOME=%JAVA_HOME:~0,-1%"
+ 
 set JAVA="%JAVA_HOME%"\bin\java
 
 
 Review comment:
   ??? this change has already existed in the master

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message